----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61053/#review181304 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp Lines 3188-3192 (original), 3188-3191 (patched) <https://reviews.apache.org/r/61053/#comment256928> Since I'm thinking of BOTTOM as UNINITIALIZED, it seems unintuitive for me to see a process in state BOTTOM when its initialize has been run and events are currently being processed. A description of what these states mean would be useful, because my current understanding isn't quite what the code does: BOTTOM: not initialized BLOCKED: initialized, no events in queue READY: initialized, events in queue - Benjamin Mahler On July 22, 2017, 1:08 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61053/ > ----------------------------------------------------------- > > (Updated July 22, 2017, 1:08 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7798 > https://issues.apache.org/jira/browse/MESOS-7798 > > > Repository: mesos > > > Description > ------- > > Removed unnecessary states RUNNING and TERMINATED. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/process.hpp > d40179f874754e00b58f271c401650138dc7d01c > 3rdparty/libprocess/src/process.cpp > b268cdad776a3ca2a87cbe60eb098bde2a70667c > > > Diff: https://reviews.apache.org/r/61053/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
