> On July 26, 2017, 10:49 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/grpc.hpp > > Lines 148 (patched) > > <https://reviews.apache.org/r/61097/diff/2/?file=1782280#file1782280line148> > > > > I would use the name `Stub` here. > > ``` > > auto call( > > const Channel& channel, > > const Stub& stub, > > const Request& request); > > ``` > > > > Also, is there a way to restrict that `Request` is a subclass of > > `protobuf::Message`?
We don't need such a restriction, since the code won't compile if the inferred signature cannot match any methods in the stub class of grpc. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61097/#review181469 ----------------------------------------------------------- On July 25, 2017, 9:13 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61097/ > ----------------------------------------------------------- > > (Updated July 25, 2017, 9:13 p.m.) > > > Review request for mesos, Benjamin Mahler, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-7810 > https://issues.apache.org/jira/browse/MESOS-7810 > > > Repository: mesos > > > Description > ------- > > A gRPC client can use `process::grpc::call(...)` to send an asynchronous > gRPC call and get a future for the response. The client needs to set up > two data structures: a `Channel` which represents a connection to a gRPC > server, and a `ClientRuntime` which maintains a `CompletionQueue` that > keeps track of all pending asynchronous gRPC calls, and spawns a thread > waiting for any response from the `CompletionQueue`. All gRPC calls > using the same `ClientRuntime` would share the same thread. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/grpc.hpp PRE-CREATION > 3rdparty/libprocess/src/grpc.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/61097/diff/2/ > > > Testing > ------- > > N/A > > > Thanks, > > Chun-Hung Hsiao > >
