----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60929/#review181589 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/master/master.proto Lines 522 (patched) <https://reviews.apache.org/r/60929/#comment257183> Missing dot at the end. :-) include/mesos/v1/master/master.proto Lines 522 (patched) <https://reviews.apache.org/r/60929/#comment257181> s/re-register/re-registers src/master/master.cpp Lines 2738 (patched) <https://reviews.apache.org/r/60929/#comment257180> Why newline here? - Anand Mazumdar On July 18, 2017, 12:18 a.m., Quinn Leng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60929/ > ----------------------------------------------------------- > > (Updated July 18, 2017, 12:18 a.m.) > > > Review request for mesos, Anand Mazumdar, Greg Mann, and Zhitao Li. > > > Bugs: MESOS-6101 > https://issues.apache.org/jira/browse/MESOS-6101 > > > Repository: mesos > > > Description > ------- > > Added event 'FRAMEWORK_UPDATED' for master's v1 streaming operator API. > It will be generated when the framework re-registers with the master. > > > Diffs > ----- > > include/mesos/master/master.proto 7a722a6deac484f28a85f63fd68ef49cb6a47606 > include/mesos/v1/master/master.proto > cf88ea64fa08e4bdcf685de4def28d374eb32fdf > src/common/protobuf_utils.hpp 2156f6d158bfee16d29aa3531bdd156af581df01 > src/common/protobuf_utils.cpp 4e5ab02c90ad8490efbcc471f7fd7c48be0c4678 > src/master/master.cpp e12c997dad04f8a4ddb47a993a84b2b05c9e2f32 > > > Diff: https://reviews.apache.org/r/60929/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Quinn Leng > >
