----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60793/#review181630 -----------------------------------------------------------
src/tests/containerizer/cni_isolator_tests.cpp Lines 1226 (patched) <https://reviews.apache.org/r/60793/#comment257253> Similar to the `DockerContainerizer` can we add a test for the flags themselves to check that we don't allow setting DNS for HOST mode? Also, would be great to test the matching algorithm we use to setup the DNS when we have multiple DNS entries. - Avinash sridharan On July 25, 2017, 6:08 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60793/ > ----------------------------------------------------------- > > (Updated July 25, 2017, 6:08 a.m.) > > > Review request for mesos, Avinash sridharan and Jie Yu. > > > Bugs: MESOS-7709 > https://issues.apache.org/jira/browse/MESOS-7709 > > > Repository: mesos > > > Description > ------- > > Added a test `CniIsolatorTest.ROOT_VerifyDefaultDNS`. > > > Diffs > ----- > > src/tests/containerizer/cni_isolator_tests.cpp > ae0980bd671849fcd3e19941b33c7d3b09fdae7c > > > Diff: https://reviews.apache.org/r/60793/diff/3/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
