----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55315/#review181635 -----------------------------------------------------------
Fix it, then Ship it! Could you also clarify what the bugs are? Would be nice to know without having to read the diff. 3rdparty/libprocess/src/poll_socket.cpp Line 99 (original), 98 (patched) <https://reviews.apache.org/r/55315/#comment257259> Any reason you removed the other VLOGs but left this in? (also, once you remove this no need to store the error string in a variable) 3rdparty/libprocess/src/poll_socket.cpp Lines 118-121 (patched) <https://reviews.apache.org/r/55315/#comment257258> As an optimization, do you want to only do this if you need to? i.e. the "is in progress" error case - Benjamin Mahler On Jan. 8, 2017, 7:42 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55315/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2017, 7:42 a.m.) > > > Review request for mesos, Benjamin Mahler and Jie Yu. > > > Repository: mesos > > > Description > ------- > > Also inlined the lambdas to simplify the code. > > > Diffs > ----- > > 3rdparty/libprocess/src/poll_socket.cpp > 5410b07e7b2ba5de4c1b61f358b6bcb224012eda > > > Diff: https://reviews.apache.org/r/55315/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
