----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60932/#review181683 -----------------------------------------------------------
include/mesos/mesos.proto Lines 2920 (patched) <https://reviews.apache.org/r/60932/#comment257308> I think that this message describes a value, so I'd recommend calling it `Value` or even `OperationValue`. include/mesos/v1/mesos.proto Lines 2903 (patched) <https://reviews.apache.org/r/60932/#comment257309> Same comment about the name. - James Peach On July 26, 2017, 6:18 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60932/ > ----------------------------------------------------------- > > (Updated July 26, 2017, 6:18 a.m.) > > > Review request for mesos, haosdent huang, Jason Lai, Jie Yu, Qian Zhang, and > Zhitao Li. > > > Bugs: MESOS-6162 > https://issues.apache.org/jira/browse/MESOS-6162 > > > Repository: mesos > > > Description > ------- > > Only statistics information for blkio in protobuf. > > > Diffs > ----- > > include/mesos/mesos.proto 8f8079bd7c2de4e8b2f8f9a56e2731b77b8e1575 > include/mesos/v1/mesos.proto 720f307f8d738b0787e7c47be7ee15be38b2c0d0 > > > Diff: https://reviews.apache.org/r/60932/diff/5/ > > > Testing > ------- > > make > > > Thanks, > > Gilbert Song > >
