----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61154/#review181769 -----------------------------------------------------------
Fix it, then Ship it! Not sure I like the call-site code that results from this, since it seems prone to confusion, but up to you. 3rdparty/libprocess/include/process/socket.hpp Lines 420-422 (patched) <https://reviews.apache.org/r/61154/#comment257469> This seems to generate code that is prone to confusion in the call sites IMO. 3rdparty/libprocess/include/process/socket.hpp Lines 440-441 (patched) <https://reviews.apache.org/r/61154/#comment257470> Commit this separately? - Benjamin Mahler On July 27, 2017, 1:55 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61154/ > ----------------------------------------------------------- > > (Updated July 27, 2017, 1:55 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Added safe downcasts for Socket. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/socket.hpp > ae6154d5d142f65352e00f37b4e66d0b62fdc3c2 > > > Diff: https://reviews.apache.org/r/61154/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
