----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61275/#review181910 -----------------------------------------------------------
include/mesos/v1/resource_provider.hpp Line 61 (original), 63 (patched) <https://reviews.apache.org/r/61275/#comment257709> This is very unintuitive. I would take a url here instead: ``` Driver(const process::http::URL& url, ContentType contentType, const std::function<void(void)>& connected, const std::function<void(void)>& disconnected, const std::function<void(const std::queue<Event>&)>& received); ``` The construction of the `url` should be left to the caller. The caller can choose to generate the `url` based on the upid. Just imagine anyone who does not familiar with Mesos code base that wants to implement a RP using this driver. `upid` is not very intuitive to them. - Jie Yu On Aug. 1, 2017, 2:04 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61275/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2017, 2:04 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Repository: mesos > > > Description > ------- > > The UPID wil be used by the resource provider driver to determine > the endpoint of the resource provider manager API. > > > Diffs > ----- > > include/mesos/v1/resource_provider.hpp > 88b606212ea57fee1c1ea522d2dc7f8124a9adef > src/resource_provider/daemon.hpp 467a5d30510f0c8f7f042d989c615c97bbae52af > src/resource_provider/daemon.cpp adcb60af8244840c56fbd2d846bdaeecb4f62282 > src/resource_provider/driver.cpp 6778ec9c863022446f141ee88f70eb563178ea05 > src/resource_provider/local.hpp 604c5d06b393349c352d0b698609ad6bfb16454a > src/resource_provider/local.cpp a57c7c99c674f18036c36ec4b6df71947f700db8 > src/resource_provider/storage/provider.hpp > c6ea440feeb4cd79c59aa1f25851513e5d8dcc86 > src/resource_provider/storage/provider.cpp > 4c39312be5e4a6d783df3d385a66be6b3dcf8603 > src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b > > > Diff: https://reviews.apache.org/r/61275/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
