> On Aug. 3, 2017, noon, Benjamin Bannier wrote: > > src/tests/mesos.hpp > > Lines 2301 (patched) > > <https://reviews.apache.org/r/61272/diff/3/?file=1788109#file1788109line2301> > > > > How about passing this as an argument instead? It semantically belongs > > to the remote description we already pass (`url`, `contentType`).
Makes sense. By making the crendential an additional template parameter (and setting it in the v1 namespace), this would also allow us to use a `v2::DEFAULT_CREDENTIAL` or something else in the future. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61272/#review182088 ----------------------------------------------------------- On Aug. 2, 2017, 1:38 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61272/ > ----------------------------------------------------------- > > (Updated Aug. 2, 2017, 1:38 p.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-7469 > https://issues.apache.org/jira/browse/MESOS-7469 > > > Repository: mesos > > > Description > ------- > > Added a MockResourceProvider. > > > Diffs > ----- > > src/tests/mesos.hpp 6f06261d81870b923b7053daf8205327c4ac6a45 > > > Diff: https://reviews.apache.org/r/61272/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
