-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61406/#review182256
-----------------------------------------------------------




src/slave/flags.hpp
Lines 95 (patched)
<https://reviews.apache.org/r/61406/#comment258151>

    This should be a linux platform specific flag. Please guard it with `#ifdef 
__linux__`



src/slave/flags.cpp
Lines 453 (patched)
<https://reviews.apache.org/r/61406/#comment258152>

    I'd suggest using the following name:
    `--disallow_sharing_agent_pid_namespace`
    
    I would mention in the comment that if set to `true`, and if the framework 
requests to share the agent pid namespace for the top level container, the 
conatiner launch will be rejected.


- Jie Yu


On Aug. 5, 2017, 3:06 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61406/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2017, 3:06 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, 
> and Vinod Kone.
> 
> 
> Bugs: MESOS-7853
>     https://issues.apache.org/jira/browse/MESOS-7853
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Introduced `--disallow_top_level_pid_ns_sharing` agent flag.
> 
> 
> Diffs
> -----
> 
>   docs/configuration.md 041c3dfb9c0c1718770f74dfb33a9f5d6fbe9b61 
>   src/slave/flags.hpp 032880dfa68cd29420e559d34e592e57827cfc07 
>   src/slave/flags.cpp 4171604090ffebe79fa35579458cabff7270c0de 
> 
> 
> Diff: https://reviews.apache.org/r/61406/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Reply via email to