----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61433/#review182537 -----------------------------------------------------------
Ship it! configure.ac Lines 1727-1729 (patched) <https://reviews.apache.org/r/61433/#comment258442> Your formatting is well readable but not entirely consistent with the other checks. ``` AC_CHECK_HEADERS([openssl/ssl.h], [AC_CHECK_LIB([ssl], [SSL_CTX_new], [found_ssl=yes], [], [-lcrypto])]) ``` I am a fan of consistent formatting but leaving it up to you to decide :) - hence not an "issue". - Till Toenshoff On Aug. 9, 2017, 10:46 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61433/ > ----------------------------------------------------------- > > (Updated Aug. 9, 2017, 10:46 p.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Till Toenshoff. > > > Bugs: MESOS-7870 > https://issues.apache.org/jira/browse/MESOS-7870 > > > Repository: mesos > > > Description > ------- > > Since gRPC requires OpenSSL, we checks if libssl and libcrypto exist no > matter if the `--enable-ssl` flag is on. This enables us to have a > non-SSL-enabled Mesos build with gRPC support. Also fixed errors that > a bad linker might link the configure tests with libssl unnecessarily, > which would cause runtime failures if libssl is not in the runtime > library search path. > > > Diffs > ----- > > configure.ac 5a6e42c61e6752c3742532502dbc753071b31323 > > > Diff: https://reviews.apache.org/r/61433/diff/4/ > > > Testing > ------- > > Ran `make check` on the following two configurations: > 1. ../configure > 2. ../configure --enable-ssl --enable-libevent > > > Thanks, > > Chun-Hung Hsiao > >
