-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61517/#review182542
-----------------------------------------------------------


Ship it!





3rdparty/libprocess/configure.ac
Lines 957-959 (patched)
<https://reviews.apache.org/r/61517/#comment258444>

    See my (non issue) comment in the previous one.


- Till Toenshoff


On Aug. 9, 2017, 10:47 p.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61517/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2017, 10:47 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Jie Yu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-7870
>     https://issues.apache.org/jira/browse/MESOS-7870
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since gRPC requires OpenSSL, we checks if libssl and libcrypto exist no
> matter if the `--enable-ssl` flag is on. This enables us to have a
> non-SSL-enabled libprocess build with gRPC support. Also fixed an error
> that a bad linker might link a configure test with libssl unnecessarily,
> which would cause a runtime failure if libssl is not in the runtime
> library search path.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/configure.ac 29b69b97428a8d5fead09e507ae0e98a46761464 
> 
> 
> Diff: https://reviews.apache.org/r/61517/diff/2/
> 
> 
> Testing
> -------
> 
> Ran `make check` on the following two configurations:
> 1. ../configure
> 2. ../configure --enable-ssl --enable-libevent
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Reply via email to