----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61565/#review182696 -----------------------------------------------------------
Patch looks great! Reviews applied: [61511, 61564, 61565] Logs available here: http://104.210.40.105/logs/master/61565 - Mesos Reviewbot Windows On Aug. 10, 2017, 5:52 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61565/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2017, 5:52 p.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Prefer checking whether a container is empty instead of checking its > size. > > > Diffs > ----- > > 3rdparty/stout/tests/flags_tests.cpp > d78ab55b983ff6918733617ae8db5be29f817c69 > 3rdparty/stout/tests/multimap_tests.cpp > 36860e43efab04cf8a2276523e6937c1918d5a90 > 3rdparty/stout/tests/os/filesystem_tests.cpp > 841f655a19e87657de77cb57c30b8310bb5898a4 > 3rdparty/stout/tests/os/process_tests.cpp > 4b5c25782dd67624bf139ad826142183a6d6f1a2 > 3rdparty/stout/tests/os_tests.cpp e8ecece1d5361e8d0e1ad42682db51b48ab6be1f > 3rdparty/stout/tests/proc_tests.cpp > c6d1d442df3e38d1d89716dc036b4a57ab0941b1 > 3rdparty/stout/tests/strings_tests.cpp > a51144df652c5d456d8dab49ca8b2cbec69ea4b6 > > > Diff: https://reviews.apache.org/r/61565/diff/2/ > > > Testing > ------- > > The stout tests still pass. > > > Thanks, > > Gastón Kleiman > >