----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61408/#review182655 -----------------------------------------------------------
src/tests/api_tests.cpp Lines 2905-2906 (patched) <https://reviews.apache.org/r/61408/#comment258631> How about: "This test verifies that when the operator API TEARDOWN call is made, the framework is shutdown and removed. It also confirms that authorization of this call is performed correctly." src/tests/api_tests.cpp Lines 2911-2931 (patched) <https://reviews.apache.org/r/61408/#comment258633> If you set the `permissive` bit to `true`, then I think we can get rid of these first 3 ACLs, which would improve readability a little. Then you could explicitly set an ACL for DEFAULT_CREDENTIAL_2. src/tests/api_tests.cpp Lines 2949-2953 (patched) <https://reviews.apache.org/r/61408/#comment258635> Since the containerizer is created to be injected into the agent, let's have these two blocks switch places: ``` Future<RegisterSlaveMessage> registerSlaveMessage = FUTURE_PROTOBUF(RegisterSlaveMessage(), _, _); ExecutorID executorId = DEFAULT_EXECUTOR_ID; TestContainerizer containerizer(executorId, executor); ``` src/tests/api_tests.cpp Lines 2964 (patched) <https://reviews.apache.org/r/61408/#comment258636> Is this necessary? src/tests/api_tests.cpp Lines 3024-3025 (patched) <https://reviews.apache.org/r/61408/#comment258688> Fits on one line. src/tests/api_tests.cpp Lines 3070-3071 (patched) <https://reviews.apache.org/r/61408/#comment258689> Fits on one line. - Greg Mann On Aug. 10, 2017, 10:47 p.m., Quinn Leng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61408/ > ----------------------------------------------------------- > > (Updated Aug. 10, 2017, 10:47 p.m.) > > > Review request for mesos, Anand Mazumdar and Greg Mann. > > > Bugs: MESOS-6846 > https://issues.apache.org/jira/browse/MESOS-6846 > > > Repository: mesos > > > Description > ------- > > Added test cases for teardown operation in V1 operator API. > > > Diffs > ----- > > src/tests/api_tests.cpp 75f7a585ec75f1d8b78453dd203bb78822ee7bc9 > > > Diff: https://reviews.apache.org/r/61408/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Quinn Leng > >
