----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61466/#review182754 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/nested_mesos_containerizer_tests.cpp Lines 879 (patched) <https://reviews.apache.org/r/61466/#comment258748> Could we follow the semantics in this file and use `containerid1`, `containerid2` etc.? src/tests/containerizer/nested_mesos_containerizer_tests.cpp Lines 934 (patched) <https://reviews.apache.org/r/61466/#comment258749> ditto to sandboxPath1, sandboxPath2.. - Gilbert Song On Aug. 7, 2017, 8:14 a.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61466/ > ----------------------------------------------------------- > > (Updated Aug. 7, 2017, 8:14 a.m.) > > > Review request for mesos, Gastón Kleiman, Gilbert Song, Jie Yu, Kevin Klues, > and Vinod Kone. > > > Bugs: MESOS-7853 > https://issues.apache.org/jira/browse/MESOS-7853 > > > Repository: mesos > > > Description > ------- > > Added the test `ROOT_CGROUPS_LaunchNestedSharePidNamespace`. > > > Diffs > ----- > > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > e46643434dc85d766bd549a037f36a89a6738678 > > > Diff: https://reviews.apache.org/r/61466/diff/1/ > > > Testing > ------- > > > Thanks, > > Qian Zhang > >
