----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61570/#review182898 -----------------------------------------------------------
src/slave/containerizer/containerizer.hpp Lines 149 (patched) <https://reviews.apache.org/r/61570/#comment258838> I see you followed the `attach` pattern here, but another option is to make this pure virtual and explicitly implement kill (returns unsupported failure) on docker containerizer. An advantate I see that you can look at docker containerizer and quickly see what are the things you need to implement in the future. - Vinod Kone On Aug. 14, 2017, 5:20 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61570/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2017, 5:20 p.m.) > > > Review request for mesos, Jie Yu and Vinod Kone. > > > Bugs: MESOS-7879 > https://issues.apache.org/jira/browse/MESOS-7879 > > > Repository: mesos > > > Description > ------- > > This would be used by now on for killing a container by sending > a signal to it similar to the linux equivalent `kill()` system call. > > > Diffs > ----- > > src/slave/containerizer/containerizer.hpp > 0954ed6175e4c8f963bf371e54e0f9ffe7bc9c1c > src/slave/containerizer/mesos/containerizer.hpp > fd586306f7a6d3d2cdb58481f0ef4906de8d0f88 > src/slave/containerizer/mesos/containerizer.cpp > ff192bb085f3554ad1b1f20fb73bf827bf04ef13 > > > Diff: https://reviews.apache.org/r/61570/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
