----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60622/#review182967 -----------------------------------------------------------
3rdparty/stout/include/stout/path.hpp Lines 68 (patched) <https://reviews.apache.org/r/60622/#comment258936> I don't think I would use `bool addprefix` for this logic. A URI by definition is _required_ to have the scheme. In fact, as far as I can tell from the RFC, the scheme and the host are the only required parts of a URI: scheme:[//[user[:password]@]host[:port]][/path][?query][#fragment] So using this with `addprefix = false` would _not_ return a URI, and then the function no longer makes sense. What use case drove the additoin of `bool addprefix`, can we solve it in another way? 3rdparty/stout/include/stout/path.hpp Lines 75 (patched) <https://reviews.apache.org/r/60622/#comment258938> I don't like duplicating this logic. We should keep the shared logic common to one spot, and the platform-specific logic by itself. 3rdparty/stout/include/stout/path.hpp Lines 77 (patched) <https://reviews.apache.org/r/60622/#comment258940> If this is the case, what are we doing on Linux if the path has backslashes in it? I recognize this wasn't already previously handled, but it's a good question. Should this function be normalizing as well? - Andrew Schwartzmeyer On July 3, 2017, 12:30 p.m., Jeff Coffler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60622/ > ----------------------------------------------------------- > > (Updated July 3, 2017, 12:30 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, John Kordich, Joseph Wu, and > Li Li. > > > Bugs: MESOS-6705 > https://issues.apache.org/jira/browse/MESOS-6705 > > > Repository: mesos > > > Description > ------- > > Add new stout function: path::uri (convert filename to valid URI). > > > Diffs > ----- > > 3rdparty/stout/include/stout/path.hpp > 6ee3a44cd6a878fe383aa68df40b82857b93d0b4 > 3rdparty/stout/tests/path_tests.cpp > f8c14d5aefe0b49adb778da784143a328c96183d > > > Diff: https://reviews.apache.org/r/60622/diff/1/ > > > Testing > ------- > > See upstream > > > Thanks, > > Jeff Coffler > >
