-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61668/#review182994
-----------------------------------------------------------




src/launcher/default_executor.cpp
Line 1098 (original), 1122-1130 (patched)
<https://reviews.apache.org/r/61668/#comment258979>

    I would move this to `kill()` so that the update can be sent in other kill 
paths as well (e.g., when one task in a group terminates and all others are 
killed by the executor)


- Vinod Kone


On Aug. 15, 2017, 6:59 p.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61668/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2017, 6:59 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Vinod Kone.
> 
> 
> Bugs: MESOS-6535
>     https://issues.apache.org/jira/browse/MESOS-6535
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Review: https://reviews.apache.org/r/61668
> 
> 
> Diffs
> -----
> 
>   src/launcher/default_executor.cpp c25cc941eefc0cca998a99d76497bfdd05babe92 
> 
> 
> Diff: https://reviews.apache.org/r/61668/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to