----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60592/#review183194 -----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/ports.cpp Lines 199 (patched) <https://reviews.apache.org/r/60592/#comment259209> s/watchInterval/_watchInterval src/slave/flags.hpp Lines 147 (patched) <https://reviews.apache.org/r/60592/#comment259207> We should put this flag under `ENABLE_NETWORK_PORTS_ISOLATOR` rather than `ENABLE_PORT_MAPPING_ISOLATOR`. src/slave/flags.cpp Lines 1006 (patched) <https://reviews.apache.org/r/60592/#comment259208> Kill the `\n` in the end. - Qian Zhang On July 3, 2017, 6:30 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60592/ > ----------------------------------------------------------- > > (Updated July 3, 2017, 6:30 p.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Added the `--container_ports_watch_interval` option to tune the > interval at which the `network/ports` isolator scans for rogue > listening ports. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/ports.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION > src/slave/flags.hpp 2970fea0cfac6af275a758d4bfedfe9a943c2b60 > src/slave/flags.cpp 3b02f3e909a554f15104739832ae3f252926b45f > > > Diff: https://reviews.apache.org/r/60592/diff/9/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
