----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61763/#review183276 -----------------------------------------------------------
Fix it, then Ship it! src/tests/api_tests.cpp Lines 2420-2422 (patched) <https://reviews.apache.org/r/61763/#comment259289> Before you do this, do `ASSERT_TRUE(event->get().subscribed().has_heartbeat_interval_seconds());` to make sure we don't crash during this statement. src/tests/api_tests.cpp Line 2441 (original), 2448 (patched) <https://reviews.apache.org/r/61763/#comment259291> Can't you just use `event->get().subscribed().heartbeat_interval_seconds()` here directly, and get rid of the temporary variable? - Greg Mann On Aug. 18, 2017, 11:11 p.m., Quinn Leng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61763/ > ----------------------------------------------------------- > > (Updated Aug. 18, 2017, 11:11 p.m.) > > > Review request for mesos, Anand Mazumdar and Greg Mann. > > > Bugs: MESOS-7695 > https://issues.apache.org/jira/browse/MESOS-7695 > > > Repository: mesos > > > Description > ------- > > Added the heartbeat interval parameter to the SUBSCRIBED event for > V1 operator API. Updated the heartbeat test case to check the > heartbeat interval. > > > Diffs > ----- > > include/mesos/master/master.proto 7dc5881b843addc2ec59fadb45f31049c7e5a588 > include/mesos/v1/master/master.proto > db19c5ccc8aca78f901e72f3caf6d46761270bdd > src/master/http.cpp b09a9d0ab5fab179d0e400932dce7d3ca958d7a8 > src/tests/api_tests.cpp 34480ea6818c904c64cb678562866f0b43dae0d6 > > > Diff: https://reviews.apache.org/r/61763/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Quinn Leng > >
