----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61640/#review183281 -----------------------------------------------------------
src/slave/slave.cpp Lines 3033 (patched) <https://reviews.apache.org/r/61640/#comment259299> Can you add a TODO to the protobuf that contains this enum saying that it is no longer used. Also, should we use a better named enum for this case? I would like to move towards all mesos generated updates to have reasons. - Vinod Kone On Aug. 15, 2017, 7 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61640/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2017, 7 a.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Previously, if a task was killed before delivery to a registering > executor, we sent REASON_EXECUTOR_UNREGISTERED with a message of > "Unregistered executor". Whereas this case is just that the task > was killed while queued. > > > Diffs > ----- > > src/slave/slave.cpp 7381530515f86faf4c3e8f82bcd9483f6cf0498b > src/tests/slave_recovery_tests.cpp 9ba6f6005c2edce67e1f63005518ab71ac981423 > src/tests/slave_tests.cpp 1d9d142ed9e801b79535a2c28f5a94ffbf1bf160 > > > Diff: https://reviews.apache.org/r/61640/diff/1/ > > > Testing > ------- > > Updated the tests. > > > Thanks, > > Benjamin Mahler > >
