----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60492/#review183441 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/network/ports.hpp Lines 56 (patched) <https://reviews.apache.org/r/60492/#comment259443> I'd prefer the order in the header to be the same in the corresponding source file. Please make it consistent. We usually put 'recover' method before 'prepare' method. src/slave/containerizer/mesos/isolators/network/ports.hpp Lines 68 (patched) <https://reviews.apache.org/r/60492/#comment259444> Can we use `uint16_t`? - Jie Yu On Aug. 14, 2017, 11:34 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60492/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2017, 11:34 p.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Added the skeleton of the `network/ports` isolator and wired it up > to the autotools build. Added the --enable-network-ports-isolator > configuration option to build the isolator and check for the libnl3 > dependencies. > > > Diffs > ----- > > configure.ac ee3818d404013e172bc51f11e8c5792cb335a22c > src/Makefile.am 68fff148f3d0c1710305bd9afcba62336d194b55 > src/slave/containerizer/mesos/isolators/network/ports.hpp PRE-CREATION > src/slave/containerizer/mesos/isolators/network/ports.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/60492/diff/9/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
