----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61797/#review183460 -----------------------------------------------------------
3rdparty/stout/include/stout/os/write.hpp Lines 67 (patched) <https://reviews.apache.org/r/61797/#comment259472> `std::strlen`? 3rdparty/stout/include/stout/os/write.hpp Line 60 (original), 95-99 (patched) <https://reviews.apache.org/r/61797/#comment259471> Maybe `return (result == 0) ? Nothing() : ErrnoError(result);`? - Alexander Rukletsov On Aug. 21, 2017, 8:54 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61797/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2017, 8:54 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Bannier, Benjamin > Mahler, and James Peach. > > > Bugs: MESOS-7791 > https://issues.apache.org/jira/browse/MESOS-7791 > > > Repository: mesos > > > Description > ------- > > Async-signal safe `write` function, which can take variable number of > arguments, should be used to improve signal safety. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/write.hpp > beb5bd83b52565a75e34d32b5bb17951bc799578 > > > Diff: https://reviews.apache.org/r/61797/diff/1/ > > > Testing > ------- > > sudo make check (mac os x, fedora 25) > internal CI > > > Thanks, > > Andrei Budnik > >
