----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61600/#review183531 -----------------------------------------------------------
3rdparty/libprocess/Makefile.am Line 416 (original), 413 (patched) <https://reviews.apache.org/r/61600/#comment259538> i tried to build, and somehow saw a race condition: ``` /home/ubuntu/workspace/mesos/3rdparty/libprocess/src/tests/grpc_tests.cpp:30:32: fatal error: grpc_tests.grpc.pb.h: No such file or directory compilation terminated. Makefile:1623: recipe for target 'libprocess_tests-grpc_tests.o' failed make[6]: *** [libprocess_tests-grpc_tests.o] Error 1 make[6]: *** Waiting for unfinished jobs.... ``` Looks like it's typo here :( fixed it for you - Jie Yu On Aug. 19, 2017, 12:34 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61600/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2017, 12:34 a.m.) > > > Review request for mesos, Benjamin Bannier and Jie Yu. > > > Bugs: MESOS-7889 > https://issues.apache.org/jira/browse/MESOS-7889 > > > Repository: mesos > > > Description > ------- > > Made code generation for Proobuf and gRPC more generic and changed the > variable names in `Makefile.am` to follow the same style in Mesos. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am c2fa3f9e81cb57bc9cb43f8f057014668bc49246 > > > Diff: https://reviews.apache.org/r/61600/diff/6/ > > > Testing > ------- > > make check > > > Thanks, > > Chun-Hung Hsiao > >
