----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61642/#review183547 -----------------------------------------------------------
src/slave/slave.hpp Lines 857 (patched) <https://reviews.apache.org/r/61642/#comment259553> Can you add a TODO here to ensure a framework is not considered idle until terminal updates for pending tasks are not acked? - Vinod Kone On Aug. 22, 2017, 7:46 p.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61642/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2017, 7:46 p.m.) > > > Review request for mesos, Anand Mazumdar and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > This ensures the call-sites consistently check idleness of the > framework, it also aids readability in that it clarifies that > we remove idle frameworks. > > > Diffs > ----- > > src/slave/slave.hpp 0e07a1af733003bb897cbebb7c1f64437063353d > src/slave/slave.cpp 50d2a10cd68f6611efd4e691e5325e6e0c06f33a > > > Diff: https://reviews.apache.org/r/61642/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
