> On Aug. 22, 2017, 10:46 a.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/src/subprocess_posix.hpp > > Line 194 (original), 195-197 (patched) > > <https://reviews.apache.org/r/61799/diff/1/?file=1801034#file1801034line195> > > > > Is this what `clang-format` suggests? > > Andrei Budnik wrote: > `clang-format` suggests > ```cpp > _EXIT( > errno, "Failed to os::execvpe on path '", path, "': ", > os::strerror(errno)); > ``` > which is wrong, because code style obliges us to put 4 spaces after `(`. > Also, I can't add 2 more spaces, because of 80-charactes limit. > > Alexander Rukletsov wrote: > Then you should go for > ``` > _EXIT( > errno, > "Failed to os::execvpe on path '", > path, > "': ", > os::strerror(errno)); > ```
Fixed. - Andrei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61799/#review183463 ----------------------------------------------------------- On Aug. 21, 2017, 8:54 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61799/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2017, 8:54 p.m.) > > > Review request for mesos, Alexander Rukletsov, Alexander Rojas, Benjamin > Bannier, Benjamin Mahler, and James Peach. > > > Bugs: MESOS-7791 > https://issues.apache.org/jira/browse/MESOS-7791 > > > Repository: mesos > > > Description > ------- > > Using ABORT causes coredump when path to an executable is invalid. > In addition, using of _EXIT allows us to get rid of string > concatenation, thereby making `childMain` more async-signal safe. > > > Diffs > ----- > > 3rdparty/libprocess/src/subprocess_posix.hpp > b478beccff22e2ffa08b9b91cfd5b9c6ada9b697 > > > Diff: https://reviews.apache.org/r/61799/diff/2/ > > > Testing > ------- > > sudo make check (mac os x, fedora 25) > internal CI > > > Thanks, > > Andrei Budnik > >
