-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61915/
-----------------------------------------------------------
(Updated Aug. 25, 2017, 1:32 p.m.)
Review request for mesos, Jie Yu, Joseph Wu, Kevin Klues, and Li Li.
Changes
-------
Add Linux test notes.
Bugs: MESOS-7917
https://issues.apache.org/jira/browse/MESOS-7917
Repository: mesos
Description
-------
When originally implemented this code was enabled only for Linux.
However, this code should work anywhere Docker is being used, as it
obtains the information by shelling out to the `docker` executable.
This patch fixes the resources information provided by the `mesos-agent`
on Windows platforms for Docker containers by making the `statistics`
JSON object available.
Note that the `cgroupsStatistics` is Linux specific, and so the
pre-processor guard was not removed but reduced in scope for just it.
Diffs
-----
src/slave/containerizer/docker.cpp cbcff39a5d8398f71570849615aeb4368130b433
Diff: https://reviews.apache.org/r/61915/diff/1/
Testing (updated)
-------
Built on Windows, started a Windows Docker container, observed the `statistics`
field from `<theagent>/container` being populated where it was not previously
included.
`make check` passed on CentOS 7.
Diagnosing the Windows tests, have a machine configuration with Docker
containers right now.
Thanks,
Andrew Schwartzmeyer