> On Aug. 30, 2017, 3:21 p.m., Jie Yu wrote: > > 3rdparty/libprocess/include/process/future.hpp > > Lines 1695-1696 (patched) > > <https://reviews.apache.org/r/61987/diff/1/?file=1807590#file1807590line1695> > > > > IIUC, in this example, `undiscardable([]() { ...; })` lambda won't even > > be called until the future returned by `foo()` is in a terminal state. In > > that case, if there is a discard on `future`, the `thenf` callback will set > > `future` to DISCARDED without calling `undiscardable([]() { ...; })`. > > > > Sounds like wither the lambda `[]() { ...; }` has `undiscardable` or > > not doesn't matter?
ah, I think it'll be useful when someone discard `future` when the future returned by `foo()` is already in a terminal state. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61987/#review184154 ----------------------------------------------------------- On Aug. 30, 2017, 6:30 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61987/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2017, 6:30 a.m.) > > > Review request for mesos, Benjamin Mahler, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-7926 > https://issues.apache.org/jira/browse/MESOS-7926 > > > Repository: mesos > > > Description > ------- > > This can be useful in circumstances where you don't want some > asynchronous operation to be canceled. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/future.hpp > 2f5f0a20b5a39b04fd684b1cb44b6a33b647bbef > 3rdparty/libprocess/src/tests/future_tests.cpp > 0c8725b9a5e64aaac6e3979e450a11e84f9bd45e > > > Diff: https://reviews.apache.org/r/61987/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
