> On Aug. 30, 2017, 12:49 a.m., Greg Mann wrote: > > src/tests/default_executor_tests.cpp > > Lines 2072-2073 (patched) > > <https://reviews.apache.org/r/61921/diff/1/?file=1804174#file1804174line2072> > > > > This comment is a little confusing. Maybe something like: > > > > "The test will only succeed if the executor and tasks share the same > > volume." > > Gastón Kleiman wrote: > I think that tecnically there are 3 volumes, and that even though each > one of them is different, the test will pass only if they all map to the same > path. > > I updated the patch using your suggested wording, but we might be able to > come up with something better =).
Ah yea that's fair. How about: "The test will only succeed if the task volume's source path is set to the path of the executor's persistent volume." - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61921/#review184109 ----------------------------------------------------------- On Aug. 30, 2017, 8:39 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61921/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2017, 8:39 p.m.) > > > Review request for mesos and Greg Mann. > > > Bugs: MESOS-7916 > https://issues.apache.org/jira/browse/MESOS-7916 > > > Repository: mesos > > > Description > ------- > > These tests verifies that sibling tasks can share a Volume owned by > their parent executor using 'sandbox_path' volumes. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > afe0afabf784fb65eb833beadd3c584722c321e1 > > > Diff: https://reviews.apache.org/r/61921/diff/3/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh --gtest_filter="*TasksSharingViaSandboxVolumes*" > --gtest_repeat=500 --gtest_break_on_failure` on GNU/Linux. > > > Thanks, > > Gastón Kleiman > >
