----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62051/#review184415 -----------------------------------------------------------
Patch looks great! Reviews applied: [62049, 62050, 62051] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Sept. 2, 2017, 3:16 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62051/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2017, 3:16 a.m.) > > > Review request for mesos, Chun-Hung Hsiao, Greg Mann, Jie Yu, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > This updates the comments to include my findings after having looked > into using BEV_EVENT_READING / BEV_EVENT_WRITING to handle read and > write path errors separately. Unfortunately, we cannot do this using > libevent 2.0.x (see the comments). > > This also clarifies the "dirty" SSL shutdown case and the case where > futher sends are performed on a shut down socket. > > > Diffs > ----- > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp > 0fa7565d1dc49e53890708df154c4d8ea278ad37 > > > Diff: https://reviews.apache.org/r/62051/diff/2/ > > > Testing > ------- > > N/A > > > Thanks, > > Benjamin Mahler > >
