----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61307/#review184447 -----------------------------------------------------------
Fix it, then Ship it! I'll fixup and tweak some comments. Also, I'm going to squash https://reviews.apache.org/r/61301/ into this one. src/CMakeLists.txt Lines 38-60 (original), 38-60 (patched) <https://reviews.apache.org/r/61307/#comment260611> Love the option parsing. We can do even better by separating out the JAVA sources like this: ``` PROTOC_GENERATE(JAVA TARGET mesos/executor/executor) PROTOC_GENERATE(JAVA TARGET mesos/fetcher/fetcher) PROTOC_GENERATE(JAVA TARGET mesos/mesos) PROTOC_GENERATE(JAVA TARGET mesos/scheduler/scheduler) PROTOC_GENERATE(JAVA TARGET mesos/v1/agent/agent) PROTOC_GENERATE(JAVA TARGET mesos/v1/allocator/allocator) PROTOC_GENERATE(JAVA TARGET mesos/v1/executor/executor) PROTOC_GENERATE(JAVA TARGET mesos/v1/maintenance/maintenance) PROTOC_GENERATE(JAVA TARGET mesos/v1/master/master) PROTOC_GENERATE(JAVA TARGET mesos/v1/mesos) PROTOC_GENERATE(JAVA TARGET mesos/v1/quota/quota) PROTOC_GENERATE(JAVA TARGET mesos/v1/resource_provider/resource_provider) PROTOC_GENERATE(JAVA TARGET mesos/v1/scheduler/scheduler) ``` Similar option reordering can be done for INTERNAL stuff. src/cmake/MesosProtobuf.cmake Line 19 (original), 19 (patched) <https://reviews.apache.org/r/61307/#comment260610> s/SRC/INTERNAL/ - Joseph Wu On Aug. 1, 2017, 6:05 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61307/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2017, 6:05 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-5902 > https://issues.apache.org/jira/browse/MESOS-5902 > > > Repository: mesos > > > Description > ------- > > Used `cmake_parse_arguments()` to eliminate duplicate code, and enable > generating Java Protobufs. > > > Diffs > ----- > > src/CMakeLists.txt 98ccaf41bf5e7d14164e1c8b6e49268ac865a52c > src/cmake/MesosProtobuf.cmake e30ad84c02d659c3bd698fc872085cd9a1f6e4ca > > > Diff: https://reviews.apache.org/r/61307/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
