----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61311/#review184449 -----------------------------------------------------------
Ship it! Ship It! - Joseph Wu On Aug. 1, 2017, 6:05 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61311/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2017, 6:05 p.m.) > > > Review request for mesos. > > > Bugs: MESOS-5905 > https://issues.apache.org/jira/browse/MESOS-5905 > > > Repository: mesos > > > Description > ------- > > This adds the ZooKeeper test sources to the CMake build system when Java > is enabled, and makes the tests compatible with the CMake build > structure and Windows. > > `Path::basename()` cannot be used for URIs on Windows because the > `os::PATH_SEPARATOR` is a backslash, but URIs unconditionally use > forward slashes. > > > Diffs > ----- > > src/CMakeLists.txt 98ccaf41bf5e7d14164e1c8b6e49268ac865a52c > src/tests/CMakeLists.txt 6dd2716de942adf6cefa5a464ef664f3c3ebb7a3 > src/tests/zookeeper.cpp b34ed3aa60b7e27c63b54e092279399755bc79a2 > src/zookeeper/group.cpp 0b823ecbec7d09d0c06083bf9e80fbda917125f6 > > > Diff: https://reviews.apache.org/r/61311/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
