----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62065/#review184520 -----------------------------------------------------------
Bad patch! Reviews applied: [62065, 61212] Failed command: python support/apply-reviews.py -n -r 62065 Error: 2017-09-05 09:29:58 URL:https://reviews.apache.org/r/62065/diff/raw/ [8658/8658] -> "62065.patch" [1] error: patch failed: src/python/cli_new/bin/settings.py:38 error: src/python/cli_new/bin/settings.py: patch does not apply error: patch failed: src/python/cli_new/lib/cli/tests/__init__.py:20 error: src/python/cli_new/lib/cli/tests/__init__.py: patch does not apply error: patch failed: src/python/cli_new/tests/main.py:27 error: src/python/cli_new/tests/main.py: patch does not apply Full log: https://builds.apache.org/job/Mesos-Reviewbot/19203/console - Mesos Reviewbot On Sept. 4, 2017, 4:51 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62065/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2017, 4:51 p.m.) > > > Review request for mesos and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > This command displays the agents in a cluster by > reaching the slaves endpoint of a master. It also > works when Mesos runs in High-Availability Mode. > > > Diffs > ----- > > src/python/cli_new/bin/settings.py d42df04b0ff42bb6f466842e59223cd90a74d5c0 > src/python/cli_new/lib/cli/plugins/agent/__init__.py PRE-CREATION > src/python/cli_new/lib/cli/plugins/agent/main.py PRE-CREATION > src/python/cli_new/lib/cli/tests/__init__.py > 0daf28869e107263c51653ace39e3b1826871048 > src/python/cli_new/lib/cli/tests/agent.py PRE-CREATION > src/python/cli_new/tests/main.py 3e4d2e449a6485206700b4a490d325a393d31f90 > > > Diff: https://reviews.apache.org/r/62065/diff/1/ > > > Testing > ------- > > To test with one master: > > $ ./bootstrap > $ source activate > $ mesos-cli-tests > > > To test the command in High-Availability Mode I have: > 1. Started ZooKeeper. > 2. Started two masters using the flags --zk and --quorum. > 3. Started one agent. > 4. Launched one task using ./mesos-execute > --master='zk://127.0.0.1:2181/mesos' --name='test' --command='sleep 3600'. > 5. Checked that the output of 'mesos agent list' was correct. > > I also checked that the Python linter was still working. > > > Thanks, > > Armand Grillet > >
