----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62017/#review184625 -----------------------------------------------------------
Bad patch! Reviews applied: [62017] Failed command: python support/apply-reviews.py -n -r 62017 Error: 2017-09-06 03:55:20 URL:https://reviews.apache.org/r/62017/diff/raw/ [1758/1758] -> "62017.patch" [1] error: patch failed: src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp:140 error: src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp: patch does not apply Full log: https://builds.apache.org/job/Mesos-Reviewbot/19217/console - Mesos Reviewbot On Sept. 6, 2017, 12:25 a.m., Deepak Goel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62017/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2017, 12:25 a.m.) > > > Review request for mesos and Avinash sridharan. > > > Bugs: mesos-7923 > https://issues.apache.org/jira/browse/mesos-7923 > > > Repository: mesos > > > Description > ------- > > Mesos port mapper cni plugin is a wrapper around bridge plugin > to add port mapping functionality to bridge plugin. However, in > certain cases the network creator doesn't need port mapping > functionality and just want to access bridge plugin. In this case, > the creator may not supply `args` in cni config which will makes > mesos port mapper plugin to fail. This patch makes `args` in cni > config optional for mesos port mapper plugin > > > Diffs > ----- > > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp > 43cf3e44a55c56dc8195c9cd05f6edd8bf13d448 > > > Diff: https://reviews.apache.org/r/62017/diff/4/ > > > Testing > ------- > > > Thanks, > > Deepak Goel > >
