----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62069/#review184641 -----------------------------------------------------------
src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp Lines 29 (patched) <https://reviews.apache.org/r/62069/#comment260819> This breaks compilation on POSIX targets that aren't Linux (e.g. macOS): `volume_sandbox_path_isolator_tests.cpp` is compiled for all POSIX targets (because `volume/sandbox_path` is a POSIX isolator). `tests/containerizer/docker_archive.hpp` includes `tests/containerizer/rootfs.hpp` which is only available on Linux systems. - Jan Schlicht On Sept. 4, 2017, 7:50 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62069/ > ----------------------------------------------------------- > > (Updated Sept. 4, 2017, 7:50 p.m.) > > > Review request for mesos, Gilbert Song and Joseph Wu. > > > Bugs: MESOS-7936 > https://issues.apache.org/jira/browse/MESOS-7936 > > > Repository: mesos > > > Description > ------- > > This patch moved the SANDBOX_PATH volume tests from linux filesystem > isolator tests to volume sandbox path isolator tests. > > > Diffs > ----- > > src/tests/containerizer/linux_filesystem_isolator_tests.cpp > 1ad9464e99b7dd4dfd2c9bd1a4c6c9c5cce615bd > src/tests/containerizer/volume_sandbox_path_isolator_tests.cpp > 0da01c11ea538185dae1b714a80d81a14add0f0c > > > Diff: https://reviews.apache.org/r/62069/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
