----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62003/#review184660 -----------------------------------------------------------
src/tests/containerizer/ports_isolator_tests.cpp Lines 910 (patched) <https://reviews.apache.org/r/62003/#comment260853> Why do we need this flag? src/tests/containerizer/ports_isolator_tests.cpp Lines 967-968 (patched) <https://reviews.apache.org/r/62003/#comment260851> I do not think we need this, by default the executor without `ContainerInfo` will be handled by Mesos Containerizer. src/tests/containerizer/ports_isolator_tests.cpp Lines 1051-1052 (patched) <https://reviews.apache.org/r/62003/#comment260852> Can you please elaborate a bit about this? What do you mean for `the original nested container status gets swallowed`? src/tests/containerizer/ports_isolator_tests.cpp Lines 1240 (patched) <https://reviews.apache.org/r/62003/#comment260855> Please add a comment to describe the purpose of this test. src/tests/containerizer/ports_isolator_tests.cpp Lines 1251-1254 (patched) <https://reviews.apache.org/r/62003/#comment260854> I see you set this flag below when the agent is restarted, so I think we do not need to set it here since when the agent is started for the first time `network/ports` isolator is not enabled at all. - Qian Zhang On Aug. 31, 2017, 7:16 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62003/ > ----------------------------------------------------------- > > (Updated Aug. 31, 2017, 7:16 a.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Added `network/ports` isolator nested container tests using the v1 > TaskGroups API. This tests that rogue port usage by a nested task is > detected both with and without agent recovery, and that a well-behaved > task is preserved across agent recovery. > > > Diffs > ----- > > src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/62003/diff/1/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
