> On Sept. 6, 2017, 1:48 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/CMakeLists.txt > > Lines 197-198 (patched) > > <https://reviews.apache.org/r/62105/diff/2/?file=1816646#file1816646line197> > > > > I think Joe ended up committing slightly different formatting > > conventions here, with another line break, e.g.: > > > > ``` > > set_target_properties( > > cyrus_sasl PROPERTIES > > ... > > ) > > ```
Yes, and with the trailing parentheses on the same line as the last line with content (not by itself). > On Sept. 6, 2017, 1:48 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/cmake/Versions.cmake > > Lines 7-8 (patched) > > <https://reviews.apache.org/r/62105/diff/2/?file=1816647#file1816647line7> > > > > This is a question for Joe: should we place these two lines under the > > `else ()` below, since this is only bundled on Windows? Otherwise it may > > confusingly indicate that all builds (including Linux) use this version, > > but on Linux we actually use the system library. Yeah, we should move these down into the Windows-only section - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62105/#review184728 ----------------------------------------------------------- On Sept. 6, 2017, 1:35 p.m., John Kordich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62105/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2017, 1:35 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Jeff Coffler, and Joseph Wu. > > > Bugs: MESOS-3384 > https://issues.apache.org/jira/browse/MESOS-3384 > > > Repository: mesos > > > Description > ------- > > Enabled building of the Cyrus SASL CRAM MD5 lib on Windows. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7 > 3rdparty/cmake/Versions.cmake 0b62ae96817ade616f8dfc52cf8df995f8fd8927 > 3rdparty/cyrus_sasl-2.1.27rc3.patch PRE-CREATION > > > Diff: https://reviews.apache.org/r/62105/diff/2/ > > > Testing > ------- > > > Thanks, > > John Kordich > >
