> On Sept. 6, 2017, 8:57 p.m., Benjamin Mahler wrote: > > src/slave/slave.hpp > > Lines 377-378 (original), 377-379 (patched) > > <https://reviews.apache.org/r/62040/diff/1/?file=1813268#file1813268line377> > > > > How about path and virtualPath here and "virtual path" in the logging? > > We probably should have picked these names in the files API as well, feel > > free to make that change there if you like.
Also done in https://reviews.apache.org/r/62174 - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62040/#review184732 ----------------------------------------------------------- On Sept. 7, 2017, 9:16 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62040/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2017, 9:16 p.m.) > > > Review request for mesos, Benjamin Mahler and Jason Lai. > > > Bugs: MESOS-7899 > https://issues.apache.org/jira/browse/MESOS-7899 > > > Repository: mesos > > > Description > ------- > > The same physical directory will be mounted to multiple virtual paths, > so log which virtual path in agent log. > > > Diffs > ----- > > src/slave/constants.hpp 435c37e28987119c4ef43c9dad61ac052020acd8 > src/slave/slave.hpp 7d07868451e93d34ba694d40216c1e4036fd4094 > src/slave/slave.cpp df920ec07cd59c7ba6baccfc1c20ed3809f187d6 > > > Diff: https://reviews.apache.org/r/62040/diff/2/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
