----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62147/#review184929 -----------------------------------------------------------
Ship it! src/master/master.cpp Lines 6617-6618 (patched) <https://reviews.apache.org/r/62147/#comment261138> Newline to separate the comment paragraphs? ``` // Send checkpointed resources to the agent. This is important for // the cases where the master didn't fail over. In that case, the // master might have already applied an operation that the agent // didn't see (e.g., due to a breaking connection). This message // will sync the state between the master and the agent about // checkpointed resources. // // TODO(jieyu): This message is not necessary for the case where the // master fails over. Consider moving this to `reconcileKnownSlave`. ``` - Benjamin Mahler On Sept. 7, 2017, 4:11 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62147/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2017, 4:11 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Michael Park, > and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > Added a comment about master sending a checkpointed resources message. > > > Diffs > ----- > > src/master/master.cpp 14d94cfa0e96881f77dd6e0c3449fdc0613e36ce > > > Diff: https://reviews.apache.org/r/62147/diff/1/ > > > Testing > ------- > > N/A > > > Thanks, > > Jie Yu > >
