----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61536/#review184954 -----------------------------------------------------------
src/tests/containerizer/ports_isolator_tests.cpp Lines 51 (patched) <https://reviews.apache.org/r/61536/#comment261181> The test case name should always be in the form of `xxxTest` in Mesos, so I would suggest to rename `NetworkPortsIsolator` to `NetworkPortsIsolatorUtilityTest`. - Qian Zhang On Sept. 6, 2017, 12:36 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61536/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2017, 12:36 a.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Bugs: MESOS-7675 > https://issues.apache.org/jira/browse/MESOS-7675 > > > Repository: mesos > > > Description > ------- > > Added some basic tests for the network ports isolator socket > utilities. We test that we can enumerate our own sockets and > use that to figure out what ports we are listening on. > > > Diffs > ----- > > src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 > src/tests/containerizer/ports_isolator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/61536/diff/7/ > > > Testing > ------- > > make check (Fedora 26) > > > Thanks, > > James Peach > >
