----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61982/#review184853 -----------------------------------------------------------
src/tests/default_executor_tests.cpp Line 178 (original), 166 (patched) <https://reviews.apache.org/r/61982/#comment261054> Hmmm similar to my comment below, I wonder if a new overload could also accept the ExecutorID directly. This might require another template parameter for `createExecutorInfo`? Not sure if it's worth it. src/tests/default_executor_tests.cpp Lines 168 (patched) <https://reviews.apache.org/r/61982/#comment261050> Hmmmm I wonder if we should add another overload for `createExecutorInfo` so that we don't need to stringify the resources here? src/tests/default_executor_tests.cpp Line 180 (original), 171 (patched) <https://reviews.apache.org/r/61982/#comment261057> Would it also make sense to add a FrameworkID param to the helper to avoid this line? - Greg Mann On Aug. 30, 2017, 1:05 a.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61982/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2017, 1:05 a.m.) > > > Review request for mesos, Anand Mazumdar and Greg Mann. > > > Bugs: MESOS-7916 > https://issues.apache.org/jira/browse/MESOS-7916 > > > Repository: mesos > > > Description > ------- > > Update the DefaultExecutor tests to use test helpers where possible. > Also make the boilerplate initialization code consistent across tests. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > 186b8333c02ba3b9257e19437c6d689761085362 > > > Diff: https://reviews.apache.org/r/61982/diff/3/ > > > Testing > ------- > > `sudo bin/mesos-tests.sh --gtest_filter="*DefaultExecutor*"` succeeds on > GNU/Linux > > > Thanks, > > Gastón Kleiman > >
