> On Sept. 4, 2017, 1:39 p.m., Alexander Rukletsov wrote: > > src/logging/logging.cpp > > Lines 135-139 (patched) > > <https://reviews.apache.org/r/62018/diff/1/?file=1808706#file1808706line135> > > > > This approach changes defaults for clients, who start calling > > `logging::initialize(argv0)` now. For example, according to > > https://github.com/google/glog/blob/v0.3.3/src/logging.cc#L140, > > the default for `FLAGS_logbufsecs` will change from `30` to `0`. More > > importantly, the default for `FLAGS_logtostderr` is `false` (see > > https://github.com/google/glog/blob/v0.3.3/src/logging.cc#L101), while with > > your change it will become `true`. > > > > It is hard to say whether it is an issue or not (probably not). If you > > want to code defensively, you should guard parts of this function with `if > > (_flags.isSome()) {...}`. However, I think it's fine to keep it as is, > > extending the comment here saying that glog defaults can be overridden.
The new patch adds guard parts. - Armand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62018/#review184487 ----------------------------------------------------------- On Sept. 6, 2017, 9:48 a.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62018/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2017, 9:48 a.m.) > > > Review request for mesos, Andrei Budnik and Alexander Rukletsov. > > > Bugs: MESOS-7586 > https://issues.apache.org/jira/browse/MESOS-7586 > > > Repository: mesos > > > Description > ------- > > Thiw will be used to initialize logging in the main functions > that do not use mesos::internal::logging::Flags. > > > Diffs > ----- > > src/logging/logging.hpp 0e448f25de6c66d772f5bc481fbaf4aa493fd8af > src/logging/logging.cpp 70d66a5c396f709e8f27ad0d51315ed6d257f73b > > > Diff: https://reviews.apache.org/r/62018/diff/2/ > > > Testing > ------- > > ``` > $ make check > ``` > > > Thanks, > > Armand Grillet > >
