----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62279/#review185301 -----------------------------------------------------------
Ship it! Ship It! - Alexander Rukletsov On Sept. 13, 2017, 12:03 p.m., Andrei Budnik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62279/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2017, 12:03 p.m.) > > > Review request for mesos, Alexander Rukletsov, Gastón Kleiman, Gilbert Song, > and Qian Zhang. > > > Repository: mesos > > > Description > ------- > > Processes terminated by `os::killtree` exit normally with a status code > on windows, but killed by a signal on linux. Previously, we expected > a process to be killed by a signal, which causes test failure on > windows. Since we don't care about exact value of a returned status > code in this test, this check was removed. > > > Diffs > ----- > > src/tests/default_executor_tests.cpp > 186b8333c02ba3b9257e19437c6d689761085362 > > > Diff: https://reviews.apache.org/r/62279/diff/2/ > > > Testing > ------- > > internal CI > > > Thanks, > > Andrei Budnik > >
