----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62357/#review185564 -----------------------------------------------------------
Ship it! Ship It! - Andrei Budnik On Sept. 18, 2017, 2:24 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62357/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2017, 2:24 p.m.) > > > Review request for mesos, Andrei Budnik and Alexander Rukletsov. > > > Bugs: MESOS-7586 > https://issues.apache.org/jira/browse/MESOS-7586 > > > Repository: mesos > > > Description > ------- > > The arguments `flags` and `installFailureSignalHandler` are now > swapped and `flags` is optional. The will allow the logging > initialization to be more broadly used in a future patch. > > > Diffs > ----- > > src/docker/executor.cpp e9949f652cd8527991ebfdfbf14e68b4c958fe79 > src/examples/load_generator_framework.cpp > 653ae815df2009613b8f89308ab1b5f19757825a > src/examples/no_executor_framework.cpp > 2ca240b4c998f0e33e7b09dbad9f4a7bfa0583cc > src/examples/persistent_volume_framework.cpp > bce2a2d1c73a3a1efab6d107529d9f6cfe9854da > src/examples/test_framework.cpp a6b38f02cc29682e3d3e1adf83baea061feda9e7 > src/examples/test_http_framework.cpp > 693dd47694678e7439f9d4ab0ff77b93950edf6e > src/exec/exec.cpp 65c4575f8d44a1f4d4e99350b770eb8b921c0644 > src/executor/executor.cpp 91bbd1e7651754620324e2384b7becbad9240a26 > src/launcher/default_executor.cpp 106b7f2e0244d211c66b237b5d1c51f43fc6e529 > src/launcher/executor.cpp 951597b576b4912541dd87d52dcb981393e58082 > src/launcher/fetcher.cpp 42980f5a4a40b72f754156469e9fe60a952d1d87 > src/local/main.cpp f6145b71c7ff7b454a63fd1f1865dbf7bf7345d2 > src/log/tool/benchmark.cpp 8264fdaa3316175cdb305202fd7b4968e896b968 > src/log/tool/initialize.cpp 6a12505119bebd4c5cfbe00aeb45a51ad9d62bec > src/log/tool/read.cpp 7b308986012fc14d5f01c88d2d09ceb45ad5db75 > src/log/tool/replica.cpp 45bd1f4bc54cf4c84af207c977fb78b23f042873 > src/logging/logging.hpp 0e448f25de6c66d772f5bc481fbaf4aa493fd8af > src/logging/logging.cpp 70d66a5c396f709e8f27ad0d51315ed6d257f73b > src/master/main.cpp 7e815bf89e018921757b19dc8e16e2d5139248ee > src/sched/sched.cpp ef73c1dccfd736b79f40a057951f022df7f60644 > src/scheduler/scheduler.cpp ce69258027ed50867569374d2d827fc3cc651744 > src/slave/main.cpp d53ff5013e00421ef1e13593584bd132a59738fb > src/tests/main.cpp a7dc99b90f84a1a1ea299c937fbfc84e55adad1c > > > Diff: https://reviews.apache.org/r/62357/diff/2/ > > > Testing > ------- > > ``` > make check > ``` > > > Thanks, > > Armand Grillet > >
