----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62037/#review185611 -----------------------------------------------------------
src/cli/execute.cpp Line 1026 (original), 1021 (patched) <https://reviews.apache.org/r/62037/#comment261907> Two spaces : ) src/cli/execute.cpp Lines 1076-1079 (original), 1069-1072 (patched) <https://reviews.apache.org/r/62037/#comment261908> This looks nicer: ``` EXIT(EXIT_FAILURE) << "Flags '--framework_capabilities' specifies an unknown" << " capability '" << capability << "'"; ``` src/cli/execute.cpp Lines 1083-1086 (original), 1076-1079 (patched) <https://reviews.apache.org/r/62037/#comment261909> Ditto. src/examples/no_executor_framework.cpp Line 312 (original), 319 (patched) <https://reviews.apache.org/r/62037/#comment261910> Why did you change it from ``` logging::initialize(argv[0], true, flags); // Catch signals. ``` ? - Alexander Rukletsov On Sept. 18, 2017, 2:27 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62037/ > ----------------------------------------------------------- > > (Updated Sept. 18, 2017, 2:27 p.m.) > > > Review request for mesos, Andrei Budnik and Alexander Rukletsov. > > > Bugs: MESOS-7586 > https://issues.apache.org/jira/browse/MESOS-7586 > > > Repository: mesos > > > Description > ------- > > This change reduces the number of messages "WARNING: Logging > before InitGoogleLogging() is written to STDERR". > > > Diffs > ----- > > src/checks/tcp_connect.cpp 3cb9077b9f39f69fdc152280e5b180b88e772648 > src/cli/execute.cpp e844fa46a43bdfb08246be929b7913a7997f18df > src/cli/resolve.cpp b3cba87f61dbff0e99291775a4d0908bb35ce811 > src/examples/balloon_framework.cpp a63dbab2b478b28738940114bd157a56b49d473b > src/examples/disk_full_framework.cpp > 2572c72ded86d4befc1dc137e264dfe6ff64a357 > src/examples/dynamic_reservation_framework.cpp > bb6f58ba8fb87ae37d4ae971c192a204d5a656c5 > src/examples/long_lived_framework.cpp > da632040ece591717a38b44158b3eedd9f0ae7c4 > src/examples/no_executor_framework.cpp > 2ca240b4c998f0e33e7b09dbad9f4a7bfa0583cc > src/examples/test_framework.cpp a6b38f02cc29682e3d3e1adf83baea061feda9e7 > src/examples/test_http_framework.cpp > 693dd47694678e7439f9d4ab0ff77b93950edf6e > src/launcher/fetcher.cpp 42980f5a4a40b72f754156469e9fe60a952d1d87 > src/slave/container_loggers/logrotate.cpp > 61484b18f4615e85925b26d999afb5ac3b7e32a5 > src/slave/containerizer/mesos/io/switchboard_main.cpp > fa0b29667258b6b6fb7381d8226b6dda0062629e > src/tests/main.cpp a7dc99b90f84a1a1ea299c937fbfc84e55adad1c > src/usage/main.cpp 5ad4a3ba7959e4a9b3fa05f5a2f49b02f94a0cf0 > > > Diff: https://reviews.apache.org/r/62037/diff/6/ > > > Testing > ------- > > ``` > make check > ``` > > Had an issue with ExamplesTest.DiskFullFramework that is not related. > > > Thanks, > > Armand Grillet > >
