> On Sept. 19, 2017, 6:30 a.m., Jie Yu wrote: > > src/resource_provider/registrar.cpp > > Lines 190 (patched) > > <https://reviews.apache.org/r/61528/diff/5/?file=1827899#file1827899line190> > > > > I think we want to tie the lifecycle of resource providers to the > > lifecycle of agents so that when the agent is gone, all the LRP associated > > with that agent is gone too. > > > > Given that we don't change agent ID upon slave machine reboot, i think > > it makes sense to checkpoint the local resource provider information under > > `<work_dir>/slaves/<slave_id>/resource_provider_registry/` > > > > Let's introduce a helper in `src/slave/paths.hpp|cpp` for the path > > helper
I put this state below the meta directory now. > On Sept. 19, 2017, 6:30 a.m., Jie Yu wrote: > > src/resource_provider/registry.proto > > Lines 42 (patched) > > <https://reviews.apache.org/r/61528/diff/5/?file=1827901#file1827901line42> > > > > hum, any reason we don't use: > > ``` > > message Registry { > > repeated ResourceProvider resource_providers; > > } > > ``` I followed the style in `master/registry.proto` here. I dropped the extra wrapper for now since we do not need it. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61528/#review183651 ----------------------------------------------------------- On Sept. 19, 2017, 6:53 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61528/ > ----------------------------------------------------------- > > (Updated Sept. 19, 2017, 6:53 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Bugs: MESOS-7555 > https://issues.apache.org/jira/browse/MESOS-7555 > > > Repository: mesos > > > Description > ------- > > This patch adds a registry and registrar interface for resource > provider managers. The registrar interface is modelled after the > master registrar and supports similar operations. Currently a single, > LevelDB-backed registrar is implemented which we plan to use for > resource provider managers in agents. > > Current the registry allows to add and remove resource provider IDs. > > > Diffs > ----- > > src/CMakeLists.txt 1a828c4351ded36f51ccbbe67147da2f50b9cdb1 > src/Makefile.am 93ed2bf55447e3e470d9bea8a0b61ce78aad1900 > src/resource_provider/registrar.hpp PRE-CREATION > src/resource_provider/registrar.cpp PRE-CREATION > src/resource_provider/registry.hpp PRE-CREATION > src/resource_provider/registry.proto PRE-CREATION > src/slave/paths.hpp 51b481fc0870f1e95448f85ee2fd485fceea1919 > src/slave/paths.cpp 08177bcef63b998f691be6893ab35891098a2886 > src/tests/resource_provider_manager_tests.cpp > 3bc56b51526e9dd188423f7349e74246c3295c77 > > > Diff: https://reviews.apache.org/r/61528/diff/6/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
