----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60057/ -----------------------------------------------------------
(Updated Sept. 21, 2017, 11:26 a.m.) Review request for mesos and Michael Park. Changes ------- Rebased. Repository: mesos Description ------- This member function of 'ProcessManager' was capturing a 'this' pointer when dispatching to itself, but did not properly use 'defer' or 'dispatch'. While this pattern is usually suspect, it was safe here as we can be sure that the process manager lives long enough to safely invoke the created callback. This patch removes the capture of 'this' and instead explicitly references the 'static process_manager' in the created callback to signal that we rely on external invariants. Diffs (updated) ----- 3rdparty/libprocess/src/process.cpp 7aba8f0117d8a336f39f26a82524aae174306d7f Diff: https://reviews.apache.org/r/60057/diff/3/ Changes: https://reviews.apache.org/r/60057/diff/2-3/ Testing ------- * `make check` (Fedora 25 clang-trunk w/ optimizations) Thanks, Benjamin Bannier
