> On Sept. 20, 2017, 10:29 a.m., Andrew Schwartzmeyer wrote:
> > It looks like the problem is `-isystem /usr/include` according to the
> > upstream bug report, but all of these paths should be of the form (just
> > looking over them) `-isystem /usr/include/foo` or `-isystem
> > /blah/foo/include` and not just raw `/usr/include`. Which is the
> > problematic one?
>
> Benjamin Bannier wrote:
> I am not sure I am following. If you look at how e.g., zlib includes are
> set
>
>
> https://github.com/apache/mesos/blob/11de04c1bbf65d0a90576642f8ea9574e05a317a/configure.ac#L1870
>
> we directly use the user-supplied prefix. If zlib was installed into
> `/usr` we would end up with `/usr/include` in the include lookup path.
>
> Similarly for many other dependencies.
Ah, I see. That's unfortunate; I assumed `${with_zlib}` had to be something
other than just `/usr`.
Okay, in that case, the CMake build will exhibit the same problem for the
unbundled dependencies, remove the `SYSTEM` part of their interface
specifications. Most are bundled, so there should be just a few to fix.
- Andrew
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62447/#review185805
-----------------------------------------------------------
On Sept. 21, 2017, 5:02 a.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62447/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2017, 5:02 a.m.)
>
>
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This flag break the build of mesos against system libraries
> installed under /usr, because it generates a command line
> of `-isystem /usr/include`, which is explicitly not supported
> by gcc. See also https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70129
>
>
> Diffs
> -----
>
> 3rdparty/CMakeLists.txt 2a183a4a46bf8bc97455fe02648407ba561b38e7
> configure.ac 92bc1aa5f9604e3b2b678225a57622cd2eb8679a
>
>
> Diff: https://reviews.apache.org/r/62447/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
