----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62438/#review185926 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp Lines 6753 (patched) <https://reviews.apache.org/r/62438/#comment262257> You missed a `return` here? - Jie Yu On Sept. 20, 2017, 2:24 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62438/ > ----------------------------------------------------------- > > (Updated Sept. 20, 2017, 2:24 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > In the future, agents will send updates on their total, e.g., when > resource providers are added or removed. As an update to the agent's > total resources currently triggers rescinding of all offered agent > resources, spurious updates can negatively affect in-flight offer > operations. > > This patch changes the master so that updates introducing no changes > (i.e., the new resources are identical to the old resources) are > dropped and do not trigger rescinding of offers anymore. We also > adjust the handling of oversubscribed agent resources to drop > redundant updates. > > > Diffs > ----- > > src/master/master.cpp 6d84a26bff970b842b58dfb69dbf232ba5c16a20 > > > Diff: https://reviews.apache.org/r/62438/diff/1/ > > > Testing > ------- > > Tested on a number of platforms on internal CI. > > > Thanks, > > Benjamin Bannier > >
