Re: Review Request 62531: Added authorization for 'MARK_AGENT_GONE' call.

[Mesos Reviewbot Windows]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62531/#review186088
-----------------------------------------------------------



FAIL: Some Mesos tests failed.

Reviews applied: `['62475', '62476', '62477', '62478', '62479', '62480', 
'62481', '62507', '62531']`

Failed command: `C:\mesos\src\mesos-tests.exe --verbose 
--gtest_filter="-ContentType/MasterAPITest.EventAuthorizationFiltering/1"`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62531

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62531/logs/mesos-tests-stdout.log):

```
[ RUN      ] ContentType/MasterAPITest.CreateAndDestroyVolumes/0
[       OK ] ContentType/MasterAPITest.CreateAndDestroyVolumes/0 (963 ms)
[ RUN      ] ContentType/MasterAPITest.CreateAndDestroyVolumes/1
[       OK ] ContentType/MasterAPITest.CreateAndDestroyVolumes/1 (1110 ms)
[ RUN      ] ContentType/MasterAPITest.GetWeights/0
[       OK ] ContentType/MasterAPITest.GetWeights/0 (249 ms)
[ RUN      ] ContentType/MasterAPITest.GetWeights/1
[       OK ] ContentType/MasterAPITest.GetWeights/1 (234 ms)
[ RUN      ] ContentType/MasterAPITest.UpdateWeights/0
[       OK ] ContentType/MasterAPITest.UpdateWeights/0 (289 ms)
[ RUN      ] ContentType/MasterAPITest.UpdateWeights/1
[       OK ] ContentType/MasterAPITest.UpdateWeights/1 (301 ms)
[ RUN      ] ContentType/MasterAPITest.ReadFile/0
[       OK ] ContentType/MasterAPITest.ReadFile/0 (327 ms)
[ RUN      ] ContentType/MasterAPITest.ReadFile/1
[       OK ] ContentType/MasterAPITest.ReadFile/1 (337 ms)
[ RUN      ] ContentType/MasterAPITest.ReadFileInvalidPath/0
[       OK ] ContentType/MasterAPITest.ReadFileInvalidPath/0 (211 ms)
[ RUN      ] ContentType/MasterAPITest.ReadFileInvalidPath/1
[       OK ] ContentType/MasterAPITest.ReadFileInvalidPath/1 (216 ms)
[ RUN      ] ContentType/MasterAPITest.Teardown/0
[       OK ] ContentType/MasterAPITest.Teardown/0 (939 ms)
[ RUN      ] ContentType/MasterAPITest.Teardown/1
[       OK ] ContentType/MasterAPITest.Teardown/1 (1091 ms)
[ RUN      ] ContentType/MasterAPITest.MarkRegisteredAgentGone/0

C:\mesos\mesos\3rdparty\libprocess\include\process/gmock.hpp(235): ERROR: this 
mock object (used in test ContentType/MasterAPITest.MarkRegisteredAgentGone/0) 
should be deleted but never is. Its address is @0000026D5BF22CF8.
C:\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object (used 
in test ContentType/MasterAPITest.MarkRegisteredAgentGone/0) should be deleted 
but never is. Its address is @0000026D5D295500.
ERROR: 2 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62531/logs/mesos-tests-stderr.log):

```
  scalar {
    value: 1024
  }
}
resources {
  name: "disk"
  type: SCALAR
  scalar {
    value: 1024
  }
}
resources {
  name: "ports"
  type: RANGES
  ranges {
    range {
      begin: 31000
      end: 32000
    }
  }
}
checkpoint: true
port: 54003

------------------------------------------------------------
To remedy this do as follows:
Step 1: rm -f C:\Users\mesos\AppData\Local\Temp\2\FiWVVF\meta\slaves\latest
        This ensures agent doesn't recover old live executors.
Step 2: Restart the agent.
```

- Mesos Reviewbot Windows


On Sept. 25, 2017, 7:22 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62531/
> -----------------------------------------------------------
> 
> (Updated Sept. 25, 2017, 7:22 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-7446
>     https://issues.apache.org/jira/browse/MESOS-7446
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds the relevant ACL's for doing AuthZ (any or none
> access).
> 
> 
> Diffs
> -----
> 
>   include/mesos/authorizer/acls.proto 
> 9109283d81a3d25332fd74234099b5e6c9264c06 
>   include/mesos/authorizer/authorizer.proto 
> 38f0e0b48e2a243a594b5d81bddb2ce6fe4cf6bd 
>   src/authorizer/local/authorizer.cpp 
> 82ae846fd39de64704f0e8bd0fe2972f3750d2e6 
>   src/master/http.cpp 28d0393fb5962df4d731521265efd81a54e1e655 
>   src/master/master.hpp 05f88111afb4fa0e2baf57106e1479914c16a113 
>   src/tests/api_tests.cpp d260a1c9560e8ff6b46eea7f2f4ddb11e18653e3 
> 
> 
> Diff: https://reviews.apache.org/r/62531/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>